ant-ivy git commit: Update the release notes

Discussion:

Jaikiran Pai

2018-08-29 06:34:29 UTC

More of a FYI - I'm still not convinced that my fix for this handles all
the necessary cases (looks like the ArtifactOrigin#location gets used in
various different ways), so I may either revert back my changes or
decide to change it in a different way. So right now, in its current
form, my changes aren't a fix.

-Jaikiran

Repository: ant-ivy
refs/heads/master d976a4a27 -> fd81f4461
Update the release notes
Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/fd81f446
Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/fd81f446
Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/fd81f446
Branch: refs/heads/master
Commit: fd81f44619b05a176ecbf4ff1499d64b39251520
Parents: d976a4a
Authored: Wed Aug 29 08:03:13 2018 +0200
Committed: Wed Aug 29 08:05:12 2018 +0200
----------------------------------------------------------------------
asciidoc/release-notes.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/fd81f446/asciidoc/release-notes.adoc
----------------------------------------------------------------------
diff --git a/asciidoc/release-notes.adoc b/asciidoc/release-notes.adoc
index cc53bb3..efa7057 100644
--- a/asciidoc/release-notes.adoc
+++ b/asciidoc/release-notes.adoc
@@ -85,6 +85,7 @@ For details about the following changes, check our JIRA install at link:https://
- FIX: Don't throw a CircularDependencyException when parsing an import scoped dependency in dependencyManagement section of a pom (jira:IVY-1588[])
- FIX: Respect exclude regardless of resolution order (jira:IVY-1486[]) (thanks to David Turner)
- FIX: ModuleDescriptorMemoryCache didn't detect outdated entries when Ivy file was updated in the cache by another process
+- FIX: Store ArtifactOrigin's location as a URL
- IMPROVEMENT: Throw an IllegalStateException when retrieving the resolutionCacheRoot on the DefaultResolutionCacheManager if the basedir (or IvySettings) is not set (jira:IVY-1482[])
- IMPROVEMENT: Optimization: limit the revision numbers scanned if revision prefix is specified (Thanks to Ernestas Vaiciukevi&ccaron;ius)
@@ -181,7 +182,6 @@ Here is the list of people who have contributed source code and documentation up
* Tobias Himstedt
* Achim Huegen
* Pierre Hägnestrand
-* Ilya
* Matt Inger
* Anders Jacobsson
* Anders Janmyr
@@ -196,6 +196,7 @@ Here is the list of people who have contributed source code and documentation up
* Sebastian Krueger
* Thomas Kurpick
* Costin Leau
+* Ilya Leoshkevich
* Tat Leung
* Antoine Levy-Lambert
* Tony Likhite

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@ant.apache.org
For additional commands, e-mail: dev-***@ant.apache.org

Gintautas Grigelionis

2018-08-29 14:47:37 UTC

Permalink

I like the idea, though. One thing that should be investigated further is
places where location is obtained by getResource().getName()
AFAICS that happens in CacheResolver (deprecated), BasicResolver (where
also a Resource is constructed from location), and
DefaultRepositoryCacheManager. There's no uniformity in
Resource-implementing classes either, sometimes getName() works on an URI,
sometimes a path string.

Gintas

Post by Jaikiran Pai
More of a FYI - I'm still not convinced that my fix for this handles all
the necessary cases (looks like the ArtifactOrigin#location gets used in
various different ways), so I may either revert back my changes or
decide to change it in a different way. So right now, in its current
form, my changes aren't a fix.
-Jaikiran

http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/fd81f446/asciidoc/release-notes.adoc

----------------------------------------------------------------------
diff --git a/asciidoc/release-notes.adoc b/asciidoc/release-notes.adoc
index cc53bb3..efa7057 100644
--- a/asciidoc/release-notes.adoc
+++ b/asciidoc/release-notes.adoc
@@ -85,6 +85,7 @@ For details about the following changes, check our

JIRA install at link:https://

- FIX: Don't throw a CircularDependencyException when parsing an import

scoped dependency in dependencyManagement section of a pom (jira:IVY-1588[])

- FIX: Respect exclude regardless of resolution order (jira:IVY-1486[])

(thanks to David Turner)

- FIX: ModuleDescriptorMemoryCache didn't detect outdated entries when

Ivy file was updated in the cache by another process

+- FIX: Store ArtifactOrigin's location as a URL
- IMPROVEMENT: Throw an IllegalStateException when retrieving the

resolutionCacheRoot on the DefaultResolutionCacheManager if the basedir (or
IvySettings) is not set (jira:IVY-1482[])

- IMPROVEMENT: Optimization: limit the revision numbers scanned if

revision prefix is specified (Thanks to Ernestas Vaiciukevi&ccaron;ius)

@@ -181,7 +182,6 @@ Here is the list of people who have contributed

source code and documentation up

* Tobias Himstedt
* Achim Huegen
* Pierre Hägnestrand
-* Ilya
* Matt Inger
* Anders Jacobsson
* Anders Janmyr
@@ -196,6 +196,7 @@ Here is the list of people who have contributed

source code and documentation up

* Sebastian Krueger
* Thomas Kurpick
* Costin Leau
+* Ilya Leoshkevich
* Tat Leung
* Antoine Levy-Lambert
* Tony Likhite

---------------------------------------------------------------------

Maarten Coene

2018-08-29 14:57:23 UTC

Permalink

Without knowing the details of the change, one thing we should take care about is that older Ivy versions should still be able to read that property properly.
Maarten

Op woensdag 29 augustus 2018 16:48:01 CEST schreef Gintautas Grigelionis <***@gmail.com>:

I like the idea, though. One thing that should be investigated further is
places where location is obtained by getResource().getName()
AFAICS that happens in CacheResolver (deprecated), BasicResolver (where
also a Resource is constructed from location), and
DefaultRepositoryCacheManager. There's no uniformity in
Resource-implementing classes either, sometimes getName() works on an URI,
sometimes a path string.

Gintas

Repository: ant-ivy
Â refs/heads/master d976a4a27 -> fd81f4461
Update the release notes
Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant-ivy/commit/fd81f446
Tree: http://git-wip-us.apache.org/repos/asf/ant-ivy/tree/fd81f446
Diff: http://git-wip-us.apache.org/repos/asf/ant-ivy/diff/fd81f446
Branch: refs/heads/master
Commit: fd81f44619b05a176ecbf4ff1499d64b39251520
Parents: d976a4a
Authored: Wed Aug 29 08:03:13 2018 +0200
Committed: Wed Aug 29 08:05:12 2018 +0200
----------------------------------------------------------------------
Â asciidoc/release-notes.adoc | 3 ++-
Â 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/fd81f446/asciidoc/release-notes.adoc

JIRA install at link:https://

Â - FIX: Don't throw a CircularDependencyException when parsing an import

scoped dependency in dependencyManagement section of a pom (jira:IVY-1588[])

Â - FIX: Respect exclude regardless of resolution order (jira:IVY-1486[])

(thanks to David Turner)

Â - FIX: ModuleDescriptorMemoryCache didn't detect outdated entries when

Ivy file was updated in the cache by another process

+- FIX: Store ArtifactOrigin's location as a URL
Â - IMPROVEMENT: Throw an IllegalStateException when retrieving the

resolutionCacheRoot on the DefaultResolutionCacheManager if the basedir (or
IvySettings) is not set (jira:IVY-1482[])

Â - IMPROVEMENT: Optimization: limit the revision numbers scanned if

revision prefix is specified (Thanks to Ernestas Vaiciukevi&ccaron;ius)

@@ -181,7 +182,6 @@ Here is the list of people who have contributed

source code and documentation up

Â * Tobias Himstedt
Â * Achim Huegen
Â * Pierre Hägnestrand
-* Ilya
Â * Matt Inger
Â * Anders Jacobsson
Â * Anders Janmyr
@@ -196,6 +196,7 @@ Here is the list of people who have contributed

source code and documentation up

Â * Sebastian Krueger
Â * Thomas Kurpick
Â * Costin Leau
+* Ilya Leoshkevich
Â * Tat Leung
Â * Antoine Levy-Lambert
Â * Tony Likhite

---------------------------------------------------------------------

Jaikiran Pai

2018-09-10 13:39:29 UTC

Permalink

Hi Maarten,

Agreed - the change(s) should be done taking into account any existing
caches (from previous version of Ivy). As of now, I have reverted my
changes which had introduced the test failures. To fix properly, it will
require a couple of hours of dedicated work to make sure all cases are
covered. However, I haven't been able to focus on it at a stretch and
would like to finish off some pending junitlauncher task work in Ant
project, before I can get to this. Hence I decided to undo my changes
for now and leave it in a state as of our latest released version.

-Jaikiran

Post by Maarten Coene
Without knowing the details of the change, one thing we should take care about is that older Ivy versions should still be able to read that property properly.
Maarten
I like the idea, though. One thing that should be investigated further is
places where location is obtained by getResource().getName()
AFAICS that happens in CacheResolver (deprecated), BasicResolver (where
also a Resource is constructed from location), and
DefaultRepositoryCacheManager. There's no uniformity in
Resource-implementing classes either, sometimes getName() works on an URI,
sometimes a path string.
Gintas

http://git-wip-us.apache.org/repos/asf/ant-ivy/blob/fd81f446/asciidoc/release-notes.adoc

JIRA install at link:https://

- FIX: Don't throw a CircularDependencyException when parsing an import

scoped dependency in dependencyManagement section of a pom (jira:IVY-1588[])

- FIX: Respect exclude regardless of resolution order (jira:IVY-1486[])

(thanks to David Turner)

- FIX: ModuleDescriptorMemoryCache didn't detect outdated entries when

Ivy file was updated in the cache by another process

+- FIX: Store ArtifactOrigin's location as a URL
- IMPROVEMENT: Throw an IllegalStateException when retrieving the

resolutionCacheRoot on the DefaultResolutionCacheManager if the basedir (or
IvySettings) is not set (jira:IVY-1482[])

- IMPROVEMENT: Optimization: limit the revision numbers scanned if

revision prefix is specified (Thanks to Ernestas Vaiciukevi&ccaron;ius)

@@ -181,7 +182,6 @@ Here is the list of people who have contributed

source code and documentation up

* Tobias Himstedt
* Achim Huegen
* Pierre Hägnestrand
-* Ilya
* Matt Inger
* Anders Jacobsson
* Anders Janmyr
@@ -196,6 +196,7 @@ Here is the list of people who have contributed

source code and documentation up

* Sebastian Krueger
* Thomas Kurpick
* Costin Leau
+* Ilya Leoshkevich
* Tat Leung
* Antoine Levy-Lambert
* Tony Likhite

---------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@ant.apache.org
For additional commands, e-mail: dev-***@ant.apache.org